StevenLuMT commented on code in PR #3353:
URL: https://github.com/apache/bookkeeper/pull/3353#discussion_r929157553


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerStorage.java:
##########
@@ -180,8 +180,9 @@ void cancelWaitForLastAddConfirmedUpdate(long ledgerId,
      * Flushes all data in the storage. Once this is called,
      * add data written to the LedgerStorage up until this point
      * has been persisted to perminant storage
+     * @param doCheckpointComplete
      */
-    void flush() throws IOException;
+    void flush(boolean doCheckpointComplete) throws IOException;

Review Comment:
   How do we charge what this value(doCheckpointComplete) is passed in? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to