rdhabalia commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r928058192
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java:
##########
@@ -1128,14 +1129,24 @@ private ArrayList<BookieId> replaceBookiesInEnsemble(
* @param ledgerFragment
* - LedgerFragment to replicate
*/
- public void replicateLedgerFragment(LedgerHandle lh,
- final LedgerFragment ledgerFragment,
- final BiConsumer<Long, Long> onReadEntryFailureCallback)
- throws InterruptedException, BKException {
- Optional<Set<BookieId>> excludedBookies = Optional.empty();
- Map<Integer, BookieId> targetBookieAddresses =
- getReplacementBookiesByIndexes(lh,
ledgerFragment.getEnsemble(),
- ledgerFragment.getBookiesIndexes(), excludedBookies);
+ public void replicateLedgerFragment(LedgerHandle lh, final LedgerFragment
ledgerFragment,
+ final BiConsumer<Long, Long> onReadEntryFailureCallback) throws
InterruptedException, BKException {
+ Map<Integer, BookieId> targetBookieAddresses = null;
+ if (LedgerFragment.ReplicateType.DATA_LOSS ==
ledgerFragment.getReplicateType()) {
Review Comment:
what's the difference between `DATA_LOSS` and `DATA_NOT_ADHERING_PLACEMENT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
