zymap commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r928385490
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java:
##########
@@ -502,10 +570,40 @@ private boolean
isLastSegmentOpenAndMissingBookies(LedgerHandle lh) throws BKExc
*/
private Set<LedgerFragment> getUnderreplicatedFragments(LedgerHandle lh,
Long ledgerVerificationPercentage)
throws InterruptedException {
+ //The data loss fragments is first to repair. If a fragment is
data_loss and not_adhering_placement
+ //at the same time, we only fix data_loss in this time. After fix
data_loss, the fragment is still
+ //not_adhering_placement, Auditor will mark this ledger again.
Review Comment:
it may introduce a double replicate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
