zymap commented on code in PR #3359:
URL: https://github.com/apache/bookkeeper/pull/3359#discussion_r929524964
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/EnsemblePlacementPolicy.java:
##########
@@ -364,6 +364,18 @@ DistributionSchedule.WriteSet reorderReadLACSequence(
default void updateBookieInfo(Map<BookieId, BookieInfo> bookieInfoMap) {
}
+ /**
+ * Replace some bookie to adhering placement policy. If the all kinds of
replacement
+ * didn't adhere placement policy, return empty map.
+ *
+ * @param ensemble
+ * @param writeQuorumSize
+ * @param ackQuorumSize
+ * @return Map: key means ensemble index, value means target replace
bookieId.
+ */
+ Map<Integer, BookieId>
replaceNotAdheringPlacementPolicyBookie(List<BookieId> ensemble, int
writeQuorumSize,
Review Comment:
If we cherry-pick this to a minor release, this will break the existing
implementation which is out of this repo. So I would suggest using the default
to avoid this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
