equanz commented on PR #2931: URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206254111
>> I notice that the implements didn’t handle the bookie which already shutdown. The shutdown bookie will be as the defaultRack, can we replace it? > > Currently, maybe, we can't do it. This feature expects all of the bookies were already recovered to a normal state. > However, your point is correct. I've checked the current code and found handing. If the `enforceMinNumRacksPerWriteQuorum` is true then handle in below. https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763f0d3f6115a066fcabe9/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L1089-L1090 However, it is not expected of me. I'll modify to add to excludeNodes regardless of `enforceMinNumRacksPerWriteQuorum` value. Moreover, `EnsemblePlacementPolicy#isEnsembleAdheringToPlacementPolicy` has a similar process like below. https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763f0d3f6115a066fcabe9/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L1043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
