equanz commented on PR #2931: URL: https://github.com/apache/bookkeeper/pull/2931#issuecomment-1206328578
In my understanding, currently, defaultRack of Rackaware is `/default-rack`. So we should consider about it if use it. https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763f0d3f6115a066fcabe9/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L138 https://github.com/equanz/bookkeeper/blob/62970b3122fa1f8266763f0d3f6115a066fcabe9/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java#L234-L248 >> However, it is not expected of me. I'll modify to add to excludeNodes regardless of enforceMinNumRacksPerWriteQuorum value. > > Yes, If we already knows which bookie shutdown, I can add it to excludeNodes to ignore it. Could you tell me more about shutdown? I think resolver doesn't return `/default-region/default-rack` just call `TopologyAwareEnsemblePlacementPolicy#handleBookiesThatJoined`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
