[ 
https://issues.apache.org/jira/browse/CALCITE-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153165#comment-15153165
 ] 

Julian Hyde commented on CALCITE-1091:
--------------------------------------

Per http://www.apache.org/dev/licensing-howto.html#bundle-asf-product, I don't 
think the NOTICE addition is required. I'd like to keep the NOTICE file small, 
so let's omit it.

Surprised that CALCITE-1093 had any effect, given that the number of result 
sets is typically very small, but whatever.

Please include "CALCITE-1086" in brackets. Trivial I know, but it makes it 
easier to grep.

Can you clarify param comments "is an update" to "is executed via 
executeUpdate". It might be, say, an INSERT or a procedure call.

A bit funny that UnsynchronizedBuffer.Writer allows a non-power-of-2 initially 
but thereafter forces to a power of 2.

I'd use Arrays.copyOf rather than System.arraycopy.

Otherwise good to go.

> Reduce Avatica RPC latency umbrella
> -----------------------------------
>
>                 Key: CALCITE-1091
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1091
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: next
>
>
> I've been spending a bit of time looking at performance improvements to 
> Avatica with the restriction of reducing the latency of operations (ignoring 
> performance gains through concurrency).
> I'll use this as an umbrella for the issues I've run into so far.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to