[
https://issues.apache.org/jira/browse/CALCITE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283097#comment-15283097
]
Julian Hyde commented on CALCITE-1150:
--------------------------------------
DynamicRecordTypeImpl's constructor calls computeDigest. But the columns may
later change. It's worth making a note that the digest is not to be relied
upon. In fact DynamicRecordTypeImpl.equals should almost certainly not call
super.equals.
Some cosmetic stuff:
* In Javadoc, can you change method javadoc from "Return ..." to "Returns ...",
"Create ..." to "Creates ..." etc. Also add <p> between paragraphs.
* Please use {{//}} rather than {{/*}} comments inside methods.
* Make RelOptTableImpl.toRel recurse once if the row type is dynamic. I think
it would be clearer.
* Remove RelDataTypeHolder.equals and .hashCode since they are the same as for
Object
I'm working on CALCITE-1208 and my changes will probably conflict with yours
but I guess I'll deal with that.
> Create the a new DynamicRecordType, avoiding star expansion when working with
> this type
> ---------------------------------------------------------------------------------------
>
> Key: CALCITE-1150
> URL: https://issues.apache.org/jira/browse/CALCITE-1150
> Project: Calcite
> Issue Type: Improvement
> Reporter: Jacques Nadeau
> Assignee: Julian Hyde
>
> DynamicRecordType can be used to leverage user-provided field implications to
> avoid schema analysis until execution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
