[
https://issues.apache.org/jira/browse/CALCITE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287923#comment-15287923
]
Jinfeng Ni commented on CALCITE-1150:
-------------------------------------
Thanks for your comments, [~julianhyde]. I modified PR based on your comments.
* Modified DynamicRecordTypeImpl such that digest is computed in constructor as
well as when a new field is added. This will make sure digest is reflecting
the latest field list. I also remove equals() and hashCode() for
DynamicRecordTypeImpl, since it could use parent's corresponding code (which
uses digest)
* Modify Javadoc.
* Changed the comments inside methods
* Changed RelOptTableImpl.toRel to use recursive call in case the row type is
dynamic.
* Removed RelDataTypeHolder.equals and hashCode.
The change is put in a separate commit to make it easier to review. We can
squash if it looks good. Thanks!
https://github.com/apache/calcite/pull/228
> Create the a new DynamicRecordType, avoiding star expansion when working with
> this type
> ---------------------------------------------------------------------------------------
>
> Key: CALCITE-1150
> URL: https://issues.apache.org/jira/browse/CALCITE-1150
> Project: Calcite
> Issue Type: Improvement
> Reporter: Jacques Nadeau
> Assignee: Julian Hyde
>
> DynamicRecordType can be used to leverage user-provided field implications to
> avoid schema analysis until execution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
