[
https://issues.apache.org/jira/browse/CALCITE-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297495#comment-15297495
]
Julian Hyde commented on CALCITE-1253:
--------------------------------------
I completed my review. I was pleased to see that tests passed, and javadoc
generation was fine. Well done.
Here are my review comments:
# Change type of {{ElasticsearchRel.Implementor.list}} from {{List<Pair<String,
String>>}} to {{List<String>}}. The left field only exists because Mongo has
two query modes: find and aggregate.
# Simplify ElasticsearchToEnumerableConverter.implement, removing unused
variables
# Convert .json to standard json format (double-quoted identifiers and strings,
see e.g. druid-wiki-model.json)
# Fix bad grammar resulting from search replace of "a Mongo" to "a
Elasticsearch", e.g. in "Enumerator that reads from a Elasticsearch type"
should be "an Elasticsearch" not "a Elasticsearch". Review all comments for
grammar.
# There are not tests for each data type (e.g. integer not null, date,
timestamp, boolean) so I expect there are bugs.
# In adapter spec, show how to write a query against a raw table (i.e. using
the {{_map}} column). Your example pre-supposes that people have built views
against the raw table, which is not valid.
# In elasticsearch_adapter.md, remove trailing spaces
# Fix indentation in java code, especially for long argument and parameter
lists. "," should be at the end of a line, not the start.
# {{ElasticsearchRules.maybeQuote}} not used; remove other unused methods and
code
# There are a few references to {{Bug.CALCITE_194_FIXED}}; makes no sense
because this is bug on the Mongo adapter
# I may be wrong, but it looks as if code has been copied the Mongo adapter
that is not needed for tests to pass. Remove the code, or better, add tests.
# I think there's a bug if I put a scalar expression into a project or filter
that the adapter cannot handle during code generation, e.g. "select x + 1 from
t", "select * from t where x + 1 > 10". For each of these, can you add tests if
it works, or log a bug?
# Can you briefly list what should be the next work? What are the bugs, missing
features? They don't need to be fixed now, but I would like to know where the
holes are.
I don't think any of these are major, in fact most are cosmetic and be fixed
quickly. If these are done in the next day or two, and we are able to get the
necessary changes committed to change calcite-test-dataset, I think we can get
the adapter into 1.8.
> Create Elasticsearch adapter for Calcite
> ----------------------------------------
>
> Key: CALCITE-1253
> URL: https://issues.apache.org/jira/browse/CALCITE-1253
> Project: Calcite
> Issue Type: New Feature
> Reporter: Subhobrata Dey
> Assignee: Julian Hyde
>
> This JIRA ticket is created to propose the addition of the new Elasticsearch
> adapter for Calcite.
> The adapter exposes a SQL interface to elasticsearch which includes
> projection, filtering, sort, fetch, offset queries.
> I have provided a couple of PRs, the first one is for the elasticsearch
> adapter & the second one is for enhancing the Vagrantfile for loading test
> data required for running the Junits.
> Currently, the support for aggregates is not provided. The work on it is in
> progress.
> Kindly evaluate my contribution & please consider it as an addition to the
> calcite project.
> Following PRs are provided:
> https://github.com/apache/calcite/pull/236
> https://github.com/vlsi/calcite-test-dataset/pull/10
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
