[
https://issues.apache.org/jira/browse/CALCITE-1253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301483#comment-15301483
]
Subhobrata Dey commented on CALCITE-1253:
-----------------------------------------
Hello [~julianhyde],
I have fixed almost all the issues. Please review & accept the contribution.
1. Change type of ElasticsearchRel.Implementor.list from List<Pair<String,
String>> to List<String>. The left field only exists because Mongo has two
query modes: find and aggregate.
Issue fixed.
2. Simplify ElasticsearchToEnumerableConverter.implement, removing unused
variables
Issue fixed.
3. Convert .json to standard json format (double-quoted identifiers and
strings, see e.g. druid-wiki-model.json)
Issue fixed.
4. Fix bad grammar resulting from search replace of "a Mongo" to "a
Elasticsearch", e.g. in "Enumerator that reads from a Elasticsearch type"
should be "an Elasticsearch" not "a Elasticsearch". Review all comments for
grammar.
Issue fixed.
5. There are not tests for each data type (e.g. integer not null, date,
timestamp, boolean) so I expect there are bugs.
Kept it as part of next tasks for enhancing the tests with foodmart dataset.
6. In adapter spec, show how to write a query against a raw table (i.e. using
the _map column). Your example pre-supposes that people have built views
against the raw table, which is not valid.
Issue fixed.
7. In elasticsearch_adapter.md, remove trailing spaces
Issue fixed.
8. Fix indentation in java code, especially for long argument and parameter
lists. "," should be at the end of a line, not the start.
Issue fixed.
9. ElasticsearchRules.maybeQuote not used; remove other unused methods and code
Issue fixed.
10. There are a few references to Bug.CALCITE_194_FIXED; makes no sense because
this is bug on the Mongo adapter
Issue fixed.
11. I may be wrong, but it looks as if code has been copied the Mongo adapter
that is not needed for tests to pass. Remove the code, or better, add tests.
Issue fixed by removing code.
12. I think there's a bug if I put a scalar expression into a project or filter
that the adapter cannot handle during code generation, e.g. "select x + 1 from
t", "select * from t where x + 1 > 10". For each of these, can you add tests if
it works, or log a bug?
Will log a bug.
13. Can you briefly list what should be the next work? What are the bugs,
missing features? They don't need to be fixed now, but I would like to know
where the holes are.
- Enhance tests with foodmart dataset.
- Support aggregation operations.
> Create Elasticsearch adapter for Calcite
> ----------------------------------------
>
> Key: CALCITE-1253
> URL: https://issues.apache.org/jira/browse/CALCITE-1253
> Project: Calcite
> Issue Type: New Feature
> Reporter: Subhobrata Dey
> Assignee: Julian Hyde
>
> This JIRA ticket is created to propose the addition of the new Elasticsearch
> adapter for Calcite.
> The adapter exposes a SQL interface to elasticsearch which includes
> projection, filtering, sort, fetch, offset queries.
> I have provided a couple of PRs, the first one is for the elasticsearch
> adapter & the second one is for enhancing the Vagrantfile for loading test
> data required for running the Junits.
> Currently, the support for aggregates is not provided. The work on it is in
> progress.
> Kindly evaluate my contribution & please consider it as an addition to the
> calcite project.
> Following PRs are provided:
> https://github.com/apache/calcite/pull/236
> https://github.com/vlsi/calcite-test-dataset/pull/10
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
