[ 
https://issues.apache.org/jira/browse/CALCITE-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386434#comment-15386434
 ] 

Jinfeng Ni commented on CALCITE-1321:
-------------------------------------

The majority of code change seems to new unit test, which has better put the 
expected explain result in SqlToRelConveterTest.xml, in stead of in 
SqlToRelConverterTest.java.  

I agree the transformation had better expressed as a planner rule, so that 
people has the control whether they want such transformation, and when they 
want to apply such transformation.  Using SqlToRelConverter property is a step 
towards the first goal. 


> In-list to join optimization should have configurable in-list size 
> -------------------------------------------------------------------
>
>                 Key: CALCITE-1321
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1321
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Gautam Kumar Parai
>            Assignee: Gautam Kumar Parai
>
> We current have a default in-list size of 20. Instead of the magic number 20, 
> we should make this configurable.
> {code}
> select count(*) from table where col in 
> (1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to