[ 
https://issues.apache.org/jira/browse/CALCITE-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386484#comment-15386484
 ] 

Julian Hyde commented on CALCITE-1321:
--------------------------------------

Until CALCITE-816, using a rule was not feasible, because there was no way to 
represent an IN expression in the RelNode/RexNode algebra. Now it is possible, 
and I agree, it's a good option. The in-list threshold would become a property 
of the rule instance.

I'm not that keen on adding a Config object to SqlToRelConverter, but I could 
be persuaded. Adding it and not dealing with existing properties (e.g. 
trimUnusedFields) is worse, because it incurs technical debt.

[~gparai], Can you change SqlToRelConverterTest to put the plans in 
SqlToRelConverterTest.xml as the other tests do?

> In-list to join optimization should have configurable in-list size 
> -------------------------------------------------------------------
>
>                 Key: CALCITE-1321
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1321
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Gautam Kumar Parai
>            Assignee: Gautam Kumar Parai
>
> We current have a default in-list size of 20. Instead of the magic number 20, 
> we should make this configurable.
> {code}
> select count(*) from table where col in 
> (1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1,1);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to