Maryann Xue commented on CALCITE-1454:

All looks good to me, but one question: why don't we remove "allowBangEqual()" 
(and all related getters/setters) in SqlParser and replace it with 
Thank you very much for making this change, [~julianhyde]!

> Allow custom implementations of SqlConformance
> ----------------------------------------------
>                 Key: CALCITE-1454
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1454
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>             Fix For: 1.11.0
> Allow custom implementations of SqlConformance. This would mean renaming 
> {{enum SqlConformance}} to {{enum SqlConformanceEnum}}, and adding a new 
> {{interface SqlConformance}}; also {{public abstract class 
> SqlAbstractConformance implements SqlConformance}} to protect people who 
> write custom implementations of the interface from changes in future.

This message was sent by Atlassian JIRA

Reply via email to