Jacques Nadeau commented on CALCITE-1454:

I'd go one step further and remove "bangEqual" all together. I really think we 
should avoid object identity checks everywhere in Calcite. As a library with 
many consumers, the reliance on object identity checks at various places makes 
things very difficult. I've know we've been bitten by this pattern multiple 
times. I haven't seen any analyses that show this is fixing a bottleneck.

> Allow custom implementations of SqlConformance
> ----------------------------------------------
>                 Key: CALCITE-1454
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1454
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>             Fix For: 1.11.0
> Allow custom implementations of SqlConformance. This would mean renaming 
> {{enum SqlConformance}} to {{enum SqlConformanceEnum}}, and adding a new 
> {{interface SqlConformance}}; also {{public abstract class 
> SqlAbstractConformance implements SqlConformance}} to protect people who 
> write custom implementations of the interface from changes in future.

This message was sent by Atlassian JIRA

Reply via email to