[
https://issues.apache.org/jira/browse/CALCITE-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15689054#comment-15689054
]
Julian Hyde commented on CALCITE-1425:
--------------------------------------
The current commit,
https://github.com/maryannxue/calcite/commit/3f9b23ae815ca7a77e9b1793e023112c8a387dca,
looks good. A couple of comments:
* Clarify the javadoc for {{resolveColumn}}, especially the mechanism whereby
unmatched names are removed. The current javadoc is ambiguous due to both
passive voice and "should". Write "This method removes ..." or similar in the
method description, not the argument javadoc. (I like the mechanism, but
mutating arguments is a bit unusual.)
* Remove the method {{translateColumnNames}}. It is not used.
* The big {{if..else if...}} block in MockCatalogReader is unwieldy. Could you
replace with a switch? (You can switch on strings since JDK 1.7.) Or could you
just concatenate the names using "." and look up the corresponding field? (It's
OK, I know you're not relying on dots in field names for real, just in this
test.)
+1 once you've considered these issues.
> Support two-level column structure in INSERT/UPDATE/MERGE
> ---------------------------------------------------------
>
> Key: CALCITE-1425
> URL: https://issues.apache.org/jira/browse/CALCITE-1425
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.10.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Labels: phoenix
> Fix For: 1.11.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
