[
https://issues.apache.org/jira/browse/CALCITE-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704356#comment-15704356
]
Maryann Xue commented on CALCITE-1425:
--------------------------------------
Thank you very much for the review and the comments, [~julianhyde]! I was not
so sure about mutating arguments either. It's unusual and it might not be very
efficient, since the caller always needs to make a copy of the list whereas the
callee in most cases either clears the list (if all parts are resolved) or do
nothing to the list (if no part can be resolved) and in the former case
copy-on-write list won't help. So would it make sense to put it in the return
value, for example, like {{Pair< List<RelDataTypeField>, List<String> >
resolveColumn(RelDataTypeFactory typeFactory, List<String>)}}? or make {{Pair<
List<RelDataTypeField>, List<String> >}} another class?
> Support two-level column structure in INSERT/UPDATE/MERGE
> ---------------------------------------------------------
>
> Key: CALCITE-1425
> URL: https://issues.apache.org/jira/browse/CALCITE-1425
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.10.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Labels: phoenix
> Fix For: 1.11.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
