[
https://issues.apache.org/jira/browse/CALCITE-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876412#comment-15876412
]
Julian Hyde commented on CALCITE-1637:
--------------------------------------
I was glad to see that the mutable package does not reference the materialize
package. Very clean!
A few minor changes:
* In MutableRel, I think you should make type, cluster and rowType public,
apply Preconditions.checkNotNull in the constructor, and remove their accessor
methods.
* Move enum MutableRelType from MutableRel to top-level (package protected).
* Add MutableRelTest to CalciteSuite.
* Add a javadoc comment to each MutableXxx's "of" method, since that is the
official constructor API.
With those, +1.
> Add missing MutableRels for all relational expressions
> ------------------------------------------------------
>
> Key: CALCITE-1637
> URL: https://issues.apache.org/jira/browse/CALCITE-1637
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.11.0
> Reporter: Maryann Xue
> Assignee: Maryann Xue
> Fix For: 1.12.0
>
>
> Missing MutableRels include:
> MutableCalc,
> MutableCollect,
> MutableCorrelate,
> MutableExchange,
> MutableIntersect,
> MutableMinus,
> MutableSample,
> MutableSemiJoin,
> MutableTableFunctionScan,
> MutableTableModify,
> MutableUncollect,
> MutableWindow
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
