[
https://issues.apache.org/jira/browse/CALCITE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943978#comment-15943978
]
Julian Hyde commented on CALCITE-1702:
--------------------------------------
Regarding {{ModifiableViewTable.typeFactory}}. It's not OK to store a type
factory, or a type, in a table. (Type factory has the life cycle of a
statement, but a table can live longer; if we hold types in tables, we will get
memory leaks.) Remember that a RelProtoDataType is just a lambda - a "just add
water" - something that becomes a type when you bind to a type factory at a
later date. So, you can push all of that logic in ModifiableViewTable.extend
into the lambda.
Can you add a few SqlParserTest tests for extended DML.
> Support extended columns in DML
> -------------------------------
>
> Key: CALCITE-1702
> URL: https://issues.apache.org/jira/browse/CALCITE-1702
> Project: Calcite
> Issue Type: New Feature
> Affects Versions: 1.11.0
> Reporter: Kevin Liew
> Assignee: Julian Hyde
>
> DML support was partially implemented in CALCITE-493.
> I am working on a patch for the implementation and tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
