[ 
https://issues.apache.org/jira/browse/CALCITE-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15948170#comment-15948170
 ] 

Julian Hyde commented on CALCITE-1702:
--------------------------------------

Looks good. I have fixed up a bit, moving {{class RexBuilderHolder}} to a 
{{interface InitializerContext}}, and removed the {{RelDataTypeFactory}} 
arguments of {{TableNamespace.extend(SqlNodeList, RelDataTypeFactory)}} and 
{{RelOptTable.extend(List<RelDataTypeField>, RelDataTypeFactory)}}. I've pushed 
to https://github.com/julianhyde/calcite/commits/master and will shortly push 
to Apache.

> Support extended columns in DML
> -------------------------------
>
>                 Key: CALCITE-1702
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1702
>             Project: Calcite
>          Issue Type: New Feature
>    Affects Versions: 1.12.0
>            Reporter: Kevin Liew
>            Assignee: Julian Hyde
>
> DML support was partially implemented in CALCITE-493.
> I am working on a patch for the implementation and tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to