[ 
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957774#comment-15957774
 ] 

ASF GitHub Bot commented on CALCITE-1364:
-----------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/calcite-avatica/pull/3#discussion_r110034171
  
    --- Diff: 
standalone-server/src/main/java/org/apache/calcite/avatica/standalone/StandaloneServer.java
 ---
    @@ -92,7 +96,12 @@ public void join() throws InterruptedException {
     
       public static void main(String[] args) {
         final StandaloneServer server = new StandaloneServer();
    -    new JCommander(server, args);
    +    JCommander jc = new JCommander(server, args);
    +    if (server.help) {
    +      jc.usage();
    +      System.exit(1);
    --- End diff --
    
    Hm, I wonder why I didn't notice this. Thanks for calling it out.


> Bring Docker image for avatica-standalone-server into Apache
> ------------------------------------------------------------
>
>                 Key: CALCITE-1364
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1364
>             Project: Calcite
>          Issue Type: Task
>          Components: avatica
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>             Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with 
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable 
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple 
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles 
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation? 
> (https://github.com/spotify/docker-maven-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to