[
https://issues.apache.org/jira/browse/CALCITE-1364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957620#comment-15957620
]
ASF GitHub Bot commented on CALCITE-1364:
-----------------------------------------
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/calcite-avatica/pull/3#discussion_r110020200
--- Diff: docker/src/main/docker/postgresql/docker-compose.yml ---
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to you under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+version: '2'
+services:
+ avatica:
+ ports:
+ - "8765:8765"
+ links:
+ - postgresql
+ image: avatica-postgresql-server
+ command: "-u 'jdbc:postgresql://postgresql:5432/avatica' -p 8765"
+ depends_on:
+ - postgresql
+ postgresql:
+ image: postgres:9.6
+ ports:
+ # Default port for the docker image
+ - "5432:5432"
--- End diff --
Since postgres is designed to be behind avatica, it may be possible to just
set this to "5432" and not bind it to 5432 locally as well. You could get the
postgres port with `docker-compose ps` and a few other ways. Otherwise this
would conflict with postgresql already running.
> Bring Docker image for avatica-standalone-server into Apache
> ------------------------------------------------------------
>
> Key: CALCITE-1364
> URL: https://issues.apache.org/jira/browse/CALCITE-1364
> Project: Calcite
> Issue Type: Task
> Components: avatica
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: avatica-1.10.0
>
>
> I worked on making some Docker images for the standalone Avatica Server with
> HSQLDB.
> https://hub.docker.com/r/joshelser/avatica-hsqldb/
> These greatly simplify running the Avatica TCK and also provide a portable
> server that developers can use when testing custom Avatica clients.
> For >=1.9.0, we should an image into Avatica (upstream). There are a couple
> of open questions on my mind already:
> 1. What are the release-ability concerns (do we provide SNAPSHOT Dockerfiles
> but not built images as they may be interpreted as "releases")?
> 2. What ASF integrations exist (do we need to ask Infra for things?)
> 3. Are there any maven plugins we should consider for automation?
> (https://github.com/spotify/docker-maven-plugin)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
