[ 
https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109605#comment-16109605
 ] 

Jess Balint commented on CALCITE-1913:
--------------------------------------

Would you rather replace all uses of {{getDatabaseProduct()}} in, say, 
{{SqlImplementor}} by calls to the dialect where the logic resides? This means 
we either put more switch statements in {{SqlDialect}} or create subclasses to 
specialize behavior. I suggested adding subclasses for CALCITE-1841. If you 
prefer this route, I will remove the db product accessor and hide all behavior 
switches behind the {{SqlDialect}} API.

> Include DB version in SqlDialect
> --------------------------------
>
>                 Key: CALCITE-1913
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1913
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.13.0
>            Reporter: Jess Balint
>            Assignee: Jess Balint
>            Priority: Minor
>             Fix For: 1.14.0
>
>
> It would be useful to have the DB version # in the SqlDialect for unparsing



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to