[
https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109633#comment-16109633
]
Julian Hyde commented on CALCITE-1913:
--------------------------------------
I think we should strike a balance between putting the logic outside the
dialect (e.g. switch statements in SqlImplementor) and inside the dialect (i.e.
methods in SqlDialect that can be overridden in sub-classes). Both ends of the
spectrum can lead to ridiculous code.
I'm not 100% against adding version to SqlDialect. But it would make it easier
to over-use switch statements.
And by the way, a particular feature might be introduced in database version X
but people might choose not to use it until version Y. Depending too much on
versions would make it difficult to deal with that case.
> Include DB version in SqlDialect
> --------------------------------
>
> Key: CALCITE-1913
> URL: https://issues.apache.org/jira/browse/CALCITE-1913
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.13.0
> Reporter: Jess Balint
> Assignee: Jess Balint
> Priority: Minor
> Fix For: 1.14.0
>
>
> It would be useful to have the DB version # in the SqlDialect for unparsing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
