[
https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139445#comment-16139445
]
Julian Hyde commented on CALCITE-1940:
--------------------------------------
Good idea. Reviewing
https://github.com/apache/calcite/pull/514/commits/99e6ca890431d5f55be23924844f6d3f0058f364:
* Why do you need {{JdbcTable.jdbcTableName}}?
* The code in {{CalcitePrepareImpl}} that grabs a {{SqlDialect}} (in fact the
idea of a unique {{SqlDialect}} for the whole query) is dubious. What the query
is a union between a MySQL database and a PostgreSQL database?
* I like the idea of {{interface Sequence}}, and also {{JdbcSequence extends
JdbcTable implements Sequence}} is just right
* We use camel case in class names, even those containing acronyms. Please
rename {{DB2SequenceSupport}} to {{Db2SequenceSupport}},
{{MSSQLSequenceSupportResolver}} to {{MssqlSequenceSupportResolver}}
* Don't use {{FakeUtil.newInternal}}; just use {{new RuntimeException}}
Should {{SequenceSupport}} be rolled into {{Handler}}?
{{SequenceSupport.unparseSequenceVal}} definitely fits into
{{Handler.unparseCall}}. {{SequenceSupport.extract}} could go to either
{{Handler}} or {{SqlDialect}}. [~chris-baynes], what do you think?
> Implement dialect specific support for sequences
> ------------------------------------------------
>
> Key: CALCITE-1940
> URL: https://issues.apache.org/jira/browse/CALCITE-1940
> Project: Calcite
> Issue Type: Improvement
> Reporter: Christian Beikov
> Assignee: Julian Hyde
>
> The Calcite parser and validator already supports sequences but the push down
> to the JDBC level is currently limited. SInce sequences are not supported on
> all DBMS every sql dialect should have the possibility to render it's own way
> of extracting sequence information or incrementing the value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
