[
https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148776#comment-16148776
]
Chris Baynes commented on CALCITE-1940:
---------------------------------------
Sequence support is nice.
I agree that {{SequenceSupport.unparseSequenceVal}} could definitely be merged
into {{Handler.unparseCall}} with switches for {{NEXT_VALUE}} and
{{CURRENT_VALUE}}.
How about a bool flag on the {{BaseHandler}} which specifies if a dialect has
sequence support, false by default, but dialect specific handlers can override
it. Then moving {{SequenceSupport.extract}} method into the {{BaseHandler}}.
That avoids having to change the {{DatabaseProduct}} constructor.
Also, would be nice to have some tests for the unparsing for each dialect that
needs it in {{RelToSqlConverterTest}}.
About the {{CalcitePrepareImpl}} - perhaps I'm missing something, but I don't
quite understand why you need to try to extract the dialect there.
> Implement dialect specific support for sequences
> ------------------------------------------------
>
> Key: CALCITE-1940
> URL: https://issues.apache.org/jira/browse/CALCITE-1940
> Project: Calcite
> Issue Type: Improvement
> Reporter: Christian Beikov
> Assignee: Julian Hyde
>
> The Calcite parser and validator already supports sequences but the push down
> to the JDBC level is currently limited. SInce sequences are not supported on
> all DBMS every sql dialect should have the possibility to render it's own way
> of extracting sequence information or incrementing the value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
