[
https://issues.apache.org/jira/browse/CALCITE-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140476#comment-16140476
]
Julian Hyde commented on CALCITE-1967:
--------------------------------------
Very exciting - thanks!
Reviewing
https://github.com/apache/calcite/pull/528/commits/b6864d551720b7ba734de819410f4a953896a615:
* You seem to have started by copy-pasting the existing adapter. That's not
necessarily wrong, but did you consider sub-classing the existing adapter?
There are only about 50 lines different out of about 2,000 lines of code.
* Only ElasticSearchEnumerator, ElasticSearchTable, ElasticSearchSchema depend
on org.elasticsearch APIs; so could we isolate the differences between ES4 and
ES5 and re-use most of the adapter?
* We will need changes to adapter.md, elasticsearch_adapter.md, sqlline,
sqlline.bat similar to CALCITE-1253
[~sbcd90], as you wrote CALCITE-1253, can you please review what
[~christian.beikov] has done here?
> Add support for elastic search 5
> --------------------------------
>
> Key: CALCITE-1967
> URL: https://issues.apache.org/jira/browse/CALCITE-1967
> Project: Calcite
> Issue Type: Improvement
> Reporter: Christian Beikov
> Assignee: Julian Hyde
>
> The elastic search adapter seems to target versions before 5.x but it would
> be nice to also have an adapter for ES5+ so I created one that is quite
> similar to the existing adapter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
