[
https://issues.apache.org/jira/browse/CALCITE-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140492#comment-16140492
]
Christian Beikov commented on CALCITE-1967:
-------------------------------------------
Yeah I was thinking about depending on the original adapter too or maybe even
shading it, but at first I wasn't sure how much I had to rewrite and what you
would expect of a new adapter.
I don't know if subclassing will work so easy. I can try, but I am afraid that
there are some JVMs like the IBM J9 that are pretty strict about binary
compatibilty i.e. errors because of non-existing statically referenced methods
will be thrown during class loading vs. during first use(Oracle JVMs). And
obviously, there are incompatibilities between ES2 and ES5. How about a common
base module *calcite-elasticsearch-base* that contains the commonalities with
abstract methods to override and two submodules for ES2 and ES5 that each shade
the base or just normally depend on it.
> Add support for elastic search 5
> --------------------------------
>
> Key: CALCITE-1967
> URL: https://issues.apache.org/jira/browse/CALCITE-1967
> Project: Calcite
> Issue Type: Improvement
> Reporter: Christian Beikov
> Assignee: Julian Hyde
>
> The elastic search adapter seems to target versions before 5.x but it would
> be nice to also have an adapter for ES5+ so I created one that is quite
> similar to the existing adapter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
