[ 
https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152922#comment-16152922
 ] 

Christian Beikov commented on CALCITE-1940:
-------------------------------------------

No worries. I didn't bet on this getting into 1.14 especially since I wanted to 
tackle the sql dialect specific handling as part of this.
The lifecycle doesn't change, it's still bound to the schema, the handler was 
just merged into the dialect and dialect is now self configuring in the 
constructor. This is only a first step, so please don't look to deep into that 
yet.
For now, I would just like to make a {{RexSeqCall}} be executed with the 
appropriate convention. Currently, the call is implemented via RexImpTable and 
I have no idea how to force that expression be implemented by the 
JdbcConvention. Any idea how to do that?
After that, I would replace all the static {{DatabaseProduct}} usages with 
appropriate methods in the dialect to handle implementing the SQL translation. 
When I'm done with that, you can review it as a whole, but the current state is 
still incomplete.

> Implement dialect specific support for sequences
> ------------------------------------------------
>
>                 Key: CALCITE-1940
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1940
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Christian Beikov
>            Assignee: Julian Hyde
>
> The Calcite parser and validator already supports sequences but the push down 
> to the JDBC level is currently limited. SInce sequences are not supported on 
> all DBMS every sql dialect should have the possibility to render it's own way 
> of extracting sequence information or incrementing the value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to