[
https://issues.apache.org/jira/browse/CALCITE-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261407#comment-16261407
]
Julian Hyde commented on CALCITE-2061:
--------------------------------------
Reviewing
https://github.com/apache/calcite/pull/569/commits/5f314a7b3c6e04966db02a53f38429dade02e738:
* This is a good start - well done
* I fixed the white-space after "?" in my branch
https://github.com/julianhyde/calcite/tree/2061-offset-fetch-parameter
* I also added a test to JdbcTest. It has errors currently - can you fix
please? And write more tests if necessary
* Also please make sure checkstyle and all other tests pass (checkstyle
currently fails) and then let me know when you are ready for another review
> Support for dynamic parameters in offset/fetch (limit)
> ------------------------------------------------------
>
> Key: CALCITE-2061
> URL: https://issues.apache.org/jira/browse/CALCITE-2061
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.15.0
> Reporter: Enrico Olivelli
> Assignee: Julian Hyde
> Priority: Critical
>
> Fetch/Offset already support RexNode, it will be useful to support Dynamic
> parameters as well.
> This implementation is needed to be able to run Yahoo YCSB JDBC benchmarks
> which does large use of this syntax
> select .... LIMIT ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
