[ 
https://issues.apache.org/jira/browse/CALCITE-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263919#comment-16263919
 ] 

Enrico Olivelli commented on CALCITE-2061:
------------------------------------------

Yep, the error is clear.
But I can't find any way to create an accessor to dynamic parameters as 
Expression.
It seems that Expressions.dynamic() is not implemented and there is not used 
full method in RexToLixTranslator to achieve the goal, I am tring to write is 
but there is a lot of stuff to learn.
Do I have to implement such support ? I see in RexToLixTranslator that some 
support for dynamic parameters is already present.

For the scope of my urgent needs the patch is working, because I only use the 
planner.
If it is a big change as there is no such support dyn parameters in Expressions 
and you need to close 1.15 next week I propose to split this issue in two 
parts, merge this part in 1.15 and I volounteer to finish the work as soon as 
possible but it will go to 1.16.

The support for dynamic limits in planner for me is really important as it is 
used in YCSB for benchmarks.

I will continue my search for the best implementation, maybe the impl is 
trivial but I am a newbie to Calcite codebase 

> Support for dynamic parameters in offset/fetch (limit)
> ------------------------------------------------------
>
>                 Key: CALCITE-2061
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2061
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.15.0
>            Reporter: Enrico Olivelli
>            Assignee: Julian Hyde
>            Priority: Critical
>
> Fetch/Offset already support RexNode, it will be useful to support Dynamic 
> parameters as well.
> This implementation is needed to be able to run Yahoo YCSB JDBC benchmarks 
> which does large use of this syntax
> select .... LIMIT ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to