[
https://issues.apache.org/jira/browse/CALCITE-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396279#comment-16396279
]
ASF GitHub Bot commented on CALCITE-2207:
-----------------------------------------
GitHub user risdenk opened a pull request:
https://github.com/apache/calcite-avatica/pull/30
[CALCITE-2207] Enforce minimum JDK 8 via maven-enforcer-plugin
#Tested with JDK 7:
```
mvn --version
Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297;
2018-02-24T13:49:05-06:00)
Maven home: /usr/local/Cellar/maven/3.5.3/libexec
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_80.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.3", arch: "x86_64", family: "mac"
mvn clean install -DskipTests
...
[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-java) @ calcite
---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireJavaVersion
failed with message:
Detected JDK Version: 1.7.0-80 is not in the allowed range [1.8,).
...
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce (enforce-java)
on project avatica-parent: Some Enforcer rules have failed. Look above for
specific messages explaining why the rule failed. -> [Help 1]
...
```
Checked with JDK 8, 9, and 10-ea and build works as designed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/risdenk/calcite-avatica CALCITE-2207
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit 8953ad41f77126ee7ee825af65feefedb1283779
Author: Kevin Risden <krisden@...>
Date: 2018-03-13T00:12:17Z
[CALCITE-2207] Enforce minimum JDK 8 via maven-enforcer-plugin
----
> Enforce Java version via maven-enforcer-plugin
> ----------------------------------------------
>
> Key: CALCITE-2207
> URL: https://issues.apache.org/jira/browse/CALCITE-2207
> Project: Calcite
> Issue Type: Task
> Components: avatica
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Critical
> Fix For: avatica-1.12.0
>
>
> Now that jdk7 support has been dropped, we should add some logic to the build
> to fail obviously when a version of Java is used that we don't support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
