[
https://issues.apache.org/jira/browse/CALCITE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404239#comment-16404239
]
ASF GitHub Bot commented on CALCITE-2218:
-----------------------------------------
GitHub user laurentgo opened a pull request:
https://github.com/apache/calcite-avatica/pull/32
[CALCITE-2218] Fix AvaticaResultSet#getRow()
According to JDBC spec/Javadoc, ResultSet#getRow() method is 1-indexed
based, but AvaticaResultSet#getRow() is 0-indexed based.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laurentgo/calcite-avatica
laurentgo/CALCITE-2218
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 6fc4d99ac1249f81ca7aa0f736f1400e7ffe99b1
Author: Laurent Goujon <laurent.goujon@...>
Date: 2018-03-18T22:57:46Z
[CALCITE-2218] Fix AvaticaResultSet#getRow()
According to JDBC spec/Javadoc, ResultSet#getRow() method is 1-indexed
based, but AvaticaResultSet#getRow() is 0-indexed based.
----
> AvaticaResultSet#getRow() is not 1-indexed based
> ------------------------------------------------
>
> Key: CALCITE-2218
> URL: https://issues.apache.org/jira/browse/CALCITE-2218
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Laurent Goujon
> Assignee: Laurent Goujon
> Priority: Major
>
> According to javadoc, {{ResultSet#getRow()}} is 1-indexed based, returning 0
> when no result set
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
