[
https://issues.apache.org/jira/browse/CALCITE-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404289#comment-16404289
]
ASF GitHub Bot commented on CALCITE-2218:
-----------------------------------------
Github user risdenk commented on a diff in the pull request:
https://github.com/apache/calcite-avatica/pull/32#discussion_r175317194
--- Diff:
core/src/main/java/org/apache/calcite/avatica/AvaticaResultSet.java ---
@@ -398,15 +403,15 @@ public BigDecimal getBigDecimal(String columnLabel)
throws SQLException {
}
public boolean isBeforeFirst() throws SQLException {
- return row < 0;
--- End diff --
Couldn't this just be `row < 1` to avoid introducing the `beforeFirst`
variable?
> AvaticaResultSet#getRow() is not 1-indexed based
> ------------------------------------------------
>
> Key: CALCITE-2218
> URL: https://issues.apache.org/jira/browse/CALCITE-2218
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Laurent Goujon
> Assignee: Laurent Goujon
> Priority: Major
>
> According to javadoc, {{ResultSet#getRow()}} is 1-indexed based, returning 0
> when no result set
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
