[
https://issues.apache.org/jira/browse/CALCITE-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459350#comment-16459350
]
Alex Araujo commented on CALCITE-2284:
--------------------------------------
Thanks for taking a look [~risdenk].
{quote}One minor comment on the patch is that this looks like it would break
compatibility with the public HttpServer constructor.
{quote}
Good catch. I created a PR that preserves constructor compatibility. It adds a
new public constructor that accepts server customizers.
{quote}This might only need to be added the builder and not the constructor at
all?
{quote}
I considered this, but HttpServer#internalStart() would overwrite many of the
"advanced" settings needed. Applying the customizers before startup would allow
these settings to be preserved.
> Allow Jetty Server to be customized before startup
> --------------------------------------------------
>
> Key: CALCITE-2284
> URL: https://issues.apache.org/jira/browse/CALCITE-2284
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Affects Versions: 1.11.0
> Reporter: Alex Araujo
> Priority: Critical
> Attachments: CALCITE-2284.patch
>
>
> Avatica server options currently allow users to enable TLS with file based
> key stores. In order to support additional options (in memory keystores,
> dynamically loaded keys/certificates, etc.) Avatica should provide a callback
> to customize the embedded Jetty server before starting it up.
>
> This would be similar to how Spring Boot allows developers to customize the
> embedded server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
