[
https://issues.apache.org/jira/browse/CALCITE-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460055#comment-16460055
]
ASF GitHub Bot commented on CALCITE-2284:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/calcite-avatica/pull/46#discussion_r185313207
--- Diff:
server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java ---
@@ -75,6 +76,7 @@
private final AvaticaServerConfiguration config;
private final Subject subject;
private final SslContextFactory sslFactory;
+ private final List<ServerCustomizer> serverCustomizers;
--- End diff --
I think we should force this to be non-null (as you did in the Builder). An
empty list as the "default" value passed in through the constructors would let
us eliminate the if-null check elsewhere.
> Allow Jetty Server to be customized before startup
> --------------------------------------------------
>
> Key: CALCITE-2284
> URL: https://issues.apache.org/jira/browse/CALCITE-2284
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Affects Versions: 1.11.0
> Reporter: Alex Araujo
> Priority: Critical
> Attachments: CALCITE-2284.patch
>
>
> Avatica server options currently allow users to enable TLS with file based
> key stores. In order to support additional options (in memory keystores,
> dynamically loaded keys/certificates, etc.) Avatica should provide a callback
> to customize the embedded Jetty server before starting it up.
>
> This would be similar to how Spring Boot allows developers to customize the
> embedded server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
