[
https://issues.apache.org/jira/browse/CALCITE-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471352#comment-16471352
]
Karan Mehta commented on CALCITE-2294:
--------------------------------------
The {{HTTPServer}} class provides a static builder class called as {{Builder}},
however still exposes the constructor as public. This seems against the builder
pattern and breaks expectations. Can I change the constructors to private?
Also, the builder method {{withAuthentication}} makes assumptions around
{{loginServiceRealm}} and other parameters which should not be the case. Should
we refactor it as well?
[~julianhyde] [~risdenk] Any thoughts?
> Allow customization for AvaticaServerConfiguration for plugging new
> authentication mechanisms
> ---------------------------------------------------------------------------------------------
>
> Key: CALCITE-2294
> URL: https://issues.apache.org/jira/browse/CALCITE-2294
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Karan Mehta
> Priority: Major
>
> {{AvaticaServerConfiguration}} is currently only created if authentication
> mechanism such as {{BASIC, DIGEST or SPNEGO}} is provided. We can change it
> to a builder pattern to create this object and provide a way for users to
> plugin their own security configuration.
> An example here can be using it for custom config that supports MTLS.
> Thanks [~alexaraujo] for suggesting this approach.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
