[ 
https://issues.apache.org/jira/browse/CALCITE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490346#comment-16490346
 ] 

Zoltan Haindrich commented on CALCITE-2247:
-------------------------------------------

I've opened CALCITE-2326 for the generalization; I currently thinking in that 
this whole thing is not entirely about "unkownAsFalse" .... I feel that this 
logic could be possibly implemented as some kind of distributive logic - but 
that would probably add a lot of extra {{x IS NOT NULL}} -s
{code}
(p(x) and q(y)) is true => p(x) is true and q(y) is true
{code}

for the other uncovered issue I've opened: CALCITE-2327; I think that even thru 
that's a small code change - it might cause changes in many tests/etc

https://github.com/apache/calcite/pull/688 is passing tests; I even tried it on 
top of 2314 ; and it looked good to me


> Add rule to push conditions into a related disjunctive expression
> -----------------------------------------------------------------
>
>                 Key: CALCITE-2247
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2247
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>
> Simplify expressions like: {code}a = 1 AND (a = 1 OR a = 2){code} to {code}a 
> = 1{code}
> Conditions to apply will be:
> * in an AND condition there exists a comparison(c) and an OR (o)
> * o and c only reference 1 variable
> See HIVE-19097 for more info.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to