[ 
https://issues.apache.org/jira/browse/CALCITE-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494426#comment-16494426
 ] 

Jesus Camacho Rodriguez commented on CALCITE-2334:
--------------------------------------------------

bq. Is it not valid to simplify CEIL(CEIL(x TO HOUR) TO YEAR) to CEIL(x TO 
YEAR)? Because an HOUR never crosses a YEAR boundary.

What would be the expected result for {{CEIL('2011-12-31 23:59:59' TO HOUR)}}? 
{{'2011-12-31 00:00:00'}} or {{'2012-01-01 00:00:00'}}? I was not sure, that is 
why I disabled the simplification for CEIL all together in CALCITE-2332.

> Extend simplification of expressions with CEIL function over date types
> -----------------------------------------------------------------------
>
>                 Key: CALCITE-2334
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2334
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Julian Hyde
>            Priority: Minor
>
> CALCITE-2332 disables simplification of CEIL function due to correctness 
> issues.
> {{FLOOR}} and {{CEIL}} cannot be handled with the same logic. For instance, 
> {{CEIL(CEIL(x TO HOUR) TO YEAR)}} cannot be simplified, e.g., '2011-12-31 
> 23:59:59', while {{FLOOR(FLOOR(x TO HOUR) TO YEAR)}} can be simplified. 
> Hence, we need new logic to enable simplification of CEIL function on date 
> types.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to