[ 
https://issues.apache.org/jira/browse/CALCITE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525079#comment-16525079
 ] 

ASF GitHub Bot commented on CALCITE-2386:
-----------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/calcite-avatica/pull/62

    [CALCITE-2386] Naively wire up struct support

    It seems like Avatica already has struct support, but not in the particular 
code path used by sqlline. I've tried this out for utterly elementary bits, but 
no more.
    
    ```
    > select row(1, 2);
    +--------+
    | EXPR$0 |
    +--------+
    | {1, 2} |
    +--------+
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/calcite-avatica struct

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/calcite-avatica/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
    
----
commit bc4c315721387558776952d8bef723763ec69af9
Author: Kenneth Knowles <klk@...>
Date:   2018-06-27T12:49:11Z

    Naively wire up struct support

----


> Support columns containing struct / nested rows
> -----------------------------------------------
>
>                 Key: CALCITE-2386
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2386
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Kenneth Knowles
>            Priority: Major
>
> Avatica row / struct support appears not quite wired up. Using sqlline with 
> the Beam JDBC driver:
> {code}
> > select row(1, 2);
> +--------+
> | EXPR$0 |
> +--------+
> java.lang.RuntimeException: not implemented
>       at 
> org.apache.calcite.avatica.AvaticaSite.notImplemented(AvaticaSite.java:420)
>       at org.apache.calcite.avatica.AvaticaSite.get(AvaticaSite.java:302)
>       at 
> org.apache.calcite.avatica.AvaticaResultSet.getObject(AvaticaResultSet.java:377)
>       at sqlline.Rows$Row.<init>(Rows.java:175)
>       at sqlline.IncrementalRows.hasNext(IncrementalRows.java:66)
>       at sqlline.TableOutputFormat.print(TableOutputFormat.java:33)
>       at sqlline.SqlLine.print(SqlLine.java:1648)
>       at sqlline.Commands.execute(Commands.java:834)
>       at sqlline.Commands.sql(Commands.java:733)
>       at sqlline.SqlLine.dispatch(SqlLine.java:795)
>       at sqlline.SqlLine.begin(SqlLine.java:668)
>       at sqlline.SqlLine.start(SqlLine.java:373)
>       at sqlline.SqlLine.main(SqlLine.java:265)
> {code}
> Currently Avatica 1.11.0 but checking the code it looks like the same problem 
> exists today.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to