[
https://issues.apache.org/jira/browse/CALCITE-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526498#comment-16526498
]
ASF GitHub Bot commented on CALCITE-2386:
-----------------------------------------
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/calcite-avatica/pull/62#discussion_r198907512
--- Diff: core/src/main/java/org/apache/calcite/avatica/util/ArrayImpl.java
---
@@ -220,6 +220,17 @@ Object getArrayData(Object o,
AbstractCursor.ArrayAccessor componentAccessor)
// nothing to do
}
+ public static boolean equalContents(Array left, Array right) throws
SQLException {
+ ResultSet leftResultSet = left.getResultSet();
+ ResultSet rightResultSet = right.getResultSet();
+ while (leftResultSet.next() && rightResultSet.next()) {
+ if (!leftResultSet.getObject(1).equals(rightResultSet.getObject(1)))
{
--- End diff --
> Just in case either of these are ever null
And what I really meant to say was "in case `leftResultSet.getObject(1)` is
ever null" 🙃
> Support columns containing struct / nested rows
> -----------------------------------------------
>
> Key: CALCITE-2386
> URL: https://issues.apache.org/jira/browse/CALCITE-2386
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: avatica-1.13.0
>
>
> Avatica row / struct support appears not quite wired up. Using sqlline with
> the Beam JDBC driver:
> {code}
> > select row(1, 2);
> +--------+
> | EXPR$0 |
> +--------+
> java.lang.RuntimeException: not implemented
> at
> org.apache.calcite.avatica.AvaticaSite.notImplemented(AvaticaSite.java:420)
> at org.apache.calcite.avatica.AvaticaSite.get(AvaticaSite.java:302)
> at
> org.apache.calcite.avatica.AvaticaResultSet.getObject(AvaticaResultSet.java:377)
> at sqlline.Rows$Row.<init>(Rows.java:175)
> at sqlline.IncrementalRows.hasNext(IncrementalRows.java:66)
> at sqlline.TableOutputFormat.print(TableOutputFormat.java:33)
> at sqlline.SqlLine.print(SqlLine.java:1648)
> at sqlline.Commands.execute(Commands.java:834)
> at sqlline.Commands.sql(Commands.java:733)
> at sqlline.SqlLine.dispatch(SqlLine.java:795)
> at sqlline.SqlLine.begin(SqlLine.java:668)
> at sqlline.SqlLine.start(SqlLine.java:373)
> at sqlline.SqlLine.main(SqlLine.java:265)
> {code}
> Currently Avatica 1.11.0 but checking the code it looks like the same problem
> exists today.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
