[
https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564179#comment-16564179
]
Julian Hyde commented on CALCITE-2433:
--------------------------------------
JDBC describes how identifiers are to be quoted, and the behavior if they are
not, e.g.
[storesLowerCaseIdentifiers|https://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#storesLowerCaseIdentifiers()]
and {{getIdentifierQuoteString}}.
{{SqlDialect}} has similar information, e.g. {{identifierQuoteString}}. You do
not need a connection.
> SqlAdvisor.getCompletionHints is hard-coded for " quoting
> ---------------------------------------------------------
>
> Key: CALCITE-2433
> URL: https://issues.apache.org/jira/browse/CALCITE-2433
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> Relevant source:
> {code:java}
> boolean quoted = false;
> while (wordStart > 0
> && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
> --wordStart;
> }
> if ((wordStart > 0)
> && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting
> from the connection
> quoted = true;
> --wordStart;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
