[
https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586529#comment-16586529
]
Julian Hyde commented on CALCITE-2433:
--------------------------------------
Can you squash the request and let me review? There are currently 17 commits in
that PR.
I would like to see a smaller number of commits: a number of commits that each
describe a new feature, in terms that the end-user would understand, and the
various bug-fixes squashed into a single commit. The "feature" commits should
be in the positive "Provide hints when sub-query has '*'" rather than negative
"Lack of hints when sub-query has STAR".
> SqlAdvisor.getCompletionHints is hard-coded for " quoting
> ---------------------------------------------------------
>
> Key: CALCITE-2433
> URL: https://issues.apache.org/jira/browse/CALCITE-2433
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> Relevant source:
> {code:java}
> boolean quoted = false;
> while (wordStart > 0
> && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
> --wordStart;
> }
> if ((wordStart > 0)
> && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting
> from the connection
> quoted = true;
> --wordStart;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
