[ 
https://issues.apache.org/jira/browse/CALCITE-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570851#comment-16570851
 ] 

Julian Hyde commented on CALCITE-2442:
--------------------------------------

The best way to change a PR is to add a commit to the branch that the PR is 
based on. (The PR is saying, in effect "take everything in this branch".) It is 
better to add commits rather than amend existing ones. If the reviewer has 
already reviewed the PR, they can see what is the new stuff that you just 
added. A committer can easily squash multiple commits, and usually can easily 
rebase, when he or she merges to master.

> Cassandra unit test leaves stale folders in cassandra/ module on Windows
> ------------------------------------------------------------------------
>
>                 Key: CALCITE-2442
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2442
>             Project: Calcite
>          Issue Type: Bug
>          Components: cassandra
>            Reporter: Andrei Sereda
>            Priority: Major
>
> [~Sergey Nuyanzin] reported that 
> [CassandraUnit|https://github.com/jsevellec/cassandra-unit] leaves 
> {{.toDelete}} folder in maven module folder ({{cassandra/}}) rather than 
> {{target/}} where all build and temporary files should be located.
> {quote}
> There is one more strange thing (at least on Windows): while building a
> file with name ".toDelete" is generated under calcite\cassandra and it's
> not removed by the end of tests
> Is there a way to make cassandra generates these files in target directory
> e.g.?
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to