[
https://issues.apache.org/jira/browse/CALCITE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582319#comment-16582319
]
Vladimir Sitnikov commented on CALCITE-2462:
--------------------------------------------
Yet another alternative could be to make all methods of
{{RexProgramBuilderBase}} {{public}}, so {{RexProgramBuilderBase}} can be used
as Fixture itself.
I made methods like {{protected RexNode or(RexNode... nodes)}} to ensure
there's just a single way of using the class (via inheritance). Of course we
can always re-consider, however I just wanted to make a single change to target
one specific weakness of existing {{RexProgramTest}}.
> RexProgramTest: move "rex building" methods to base class
> ---------------------------------------------------------
>
> Key: CALCITE-2462
> URL: https://issues.apache.org/jira/browse/CALCITE-2462
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> RexProgramTest is quite big (2000 lines now), and "easy to use" rex building
> is useful for many tests.
> So I suggest to move methods like {{gt}}, {{lt}}, etc to the base class, so
> multiple other tests can reuse it.
> Alternative option would be to use Kotlin for builders, yet I think Java
> tests will be there for quite a while, so it would be nice to simplify them
> as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
