[
https://issues.apache.org/jira/browse/CALCITE-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583197#comment-16583197
]
Julian Hyde commented on CALCITE-2462:
--------------------------------------
This change created some warnings. We need to keep the warning count at 0.
Please fix them.
{noformat}
Compiling 148 source files to
/home/jhyde/regress/calcite/core/target/test-classes
[WARNING]
/home/jhyde/regress/calcite/core/src/test/java/org/apache/calcite/test/RexProgramTest.java:[437,27]
unknownLiteral in org.apache.calcite.test.RexProgramBuilderBase has been
deprecated
[WARNING]
/home/jhyde/regress/calcite/core/src/test/java/org/apache/calcite/test/RexProgramTest.java:[481,30]
nullLiteral in org.apache.calcite.test.RexProgramBuilderBase has been
deprecated
[WARNING]
/home/jhyde/regress/calcite/core/src/test/java/org/apache/calcite/test/RexProgramTest.java:[482,30]
nullLiteral in org.apache.calcite.test.RexProgramBuilderBase has been
deprecated
{noformat}
> RexProgramTest: move "rex building" methods to base class
> ---------------------------------------------------------
>
> Key: CALCITE-2462
> URL: https://issues.apache.org/jira/browse/CALCITE-2462
> Project: Calcite
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> RexProgramTest is quite big (2000 lines now), and "easy to use" rex building
> is useful for many tests.
> So I suggest to move methods like {{gt}}, {{lt}}, etc to the base class, so
> multiple other tests can reuse it.
> Alternative option would be to use Kotlin for builders, yet I think Java
> tests will be there for quite a while, so it would be nice to simplify them
> as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
