[
https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593037#comment-16593037
]
Vladimir Sitnikov commented on CALCITE-2470:
--------------------------------------------
Plan changes look good to me.
This agg.iq diff suspicious (the diff is GROUPING):
{noformat}
- EnumerableAggregate(group=[{2, 3, 7}], groups=[[{2, 3, 7}, {3}]],
EXPR$2=[MIN($5)], EXPR$3=[MAX($5)], $g=[GROUPING($2, $3, $7)])
+ EnumerableAggregate(group=[{2, 3, 7}], groups=[[{2, 3, 7}, {3}]],
EXPR$2=[MIN($5)], EXPR$3=[MAX($5)], $g=[GROUPING($3, $7, $2)])
{noformat}
The key code change is
org.apache.calcite.tools.RelBuilder#project(java.lang.Iterable<? extends
org.apache.calcite.rex.RexNode>, java.lang.Iterable<java.lang.String>, boolean)
, however I don't understand that at the moment
[~julianhyde], new {{RelBuilder#project}} seems to ignore given
{{Iterable<String> fieldNames}}. Is that intended? Is that a bug?
> RelBuilder.project should combine expressions if underlying node is a Project
> -----------------------------------------------------------------------------
>
> Key: CALCITE-2470
> URL: https://issues.apache.org/jira/browse/CALCITE-2470
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
> Priority: Major
> Fix For: 1.18.0
>
>
> The {{RelBuilder.project}} method should combine expressions if underlying
> node is a {{Project}}.
> For example, if {{r}} is a {{RelBuilder}} and its stack initially contains
> {code:java}
> Project(Scan(T), a, b, a + b as c){code}
> and we call (in pseudo-code)
> {code:java}
> r.project(a + c as d){code}
> then the result should be
> {code:java}
> Project(Scan(T), a + (a + b) as d){code}
> Today the result is
> {code:java}
> Project(Project(Scan(T), a, a + b as c), a + c as d){code}
> In some circumstances the result will be larger (i.e. contain more
> {{RexNode}} instances) but much more frequently the result will be smaller
> and simpler.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
