[
https://issues.apache.org/jira/browse/CALCITE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596660#comment-16596660
]
ASF GitHub Bot commented on CALCITE-2503:
-----------------------------------------
GitHub user karanmehta93 opened a pull request:
https://github.com/apache/calcite-avatica/pull/67
CALCITE-2503 AvaticaCommonsHttpClientImpl client needs to set user-to…
…ken on HttpClientContext before sending the request
@joshelser @julianhyde Review please.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karanmehta93/calcite-avatica master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/calcite-avatica/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit 2d1b96f9ce90f48bc67ffdc3da0743324f64d0bb
Author: Karan Mehta <karanmehta93@...>
Date: 2018-08-29T17:58:01Z
CALCITE-2503 AvaticaCommonsHttpClientImpl client needs to set user-token on
HttpClientContext before sending the request
----
> AvaticaCommonsHttpClientImpl client needs to set user-token on
> HttpClientContext before sending the request
> -----------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-2503
> URL: https://issues.apache.org/jira/browse/CALCITE-2503
> Project: Calcite
> Issue Type: Improvement
> Reporter: Karan Mehta
> Assignee: Karan Mehta
> Priority: Major
>
> One of the Avatica client implementations, AvaticaCommonsHttpClientImpl, uses
> a PoolingHttpClientConnectionManager. When using mutual authentication on the
> client pool, we need to ensure that we are setting a user-token on the
> HttpClientContext, otherwise it ends up creating a new connection everytime
> and not reusing it. See:
> [https://hc.apache.org/httpcomponents-client-ga/tutorial/html/advanced.html]
> for more details
> This results in significant perf degradation since every new connection tries
> to complete a SSL handshake (which is expensive)
> See:
> https://stackoverflow.com/questions/548029/how-much-overhead-does-ssl-impose
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
