[ 
https://issues.apache.org/jira/browse/CALCITE-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596854#comment-16596854
 ] 

ASF GitHub Bot commented on CALCITE-2503:
-----------------------------------------

Github user joshelser commented on the issue:

    https://github.com/apache/calcite-avatica/pull/67
  
    ```
    [ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 
1.724 s <<< FAILURE! - in org.apache.calcite.avatica.SslDriverTest
    [ERROR] testReadWrite[0](org.apache.calcite.avatica.SslDriverTest)  Time 
elapsed: 0.082 s  <<< ERROR!
    java.lang.RuntimeException: javax.net.ssl.SSLHandshakeException: Received 
fatal alert: handshake_failure
        at 
org.apache.calcite.avatica.SslDriverTest.testReadWrite(SslDriverTest.java:137)
    Caused by: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
handshake_failure
        at 
org.apache.calcite.avatica.SslDriverTest.testReadWrite(SslDriverTest.java:137)
    [ERROR] testReadWrite[1](org.apache.calcite.avatica.SslDriverTest)  Time 
elapsed: 0.037 s  <<< ERROR!
    java.lang.RuntimeException: javax.net.ssl.SSLHandshakeException: Received 
fatal alert: handshake_failure
        at 
org.apache.calcite.avatica.SslDriverTest.testReadWrite(SslDriverTest.java:137)
    Caused by: javax.net.ssl.SSLHandshakeException: Received fatal alert: 
handshake_failure
        at 
org.apache.calcite.avatica.SslDriverTest.testReadWrite(SslDriverTest.java:137)
    ```
    
    Seems like there are some issues with IBM Java, @karanmehta93. I'm not 
positive if these tests have been failing, or if they're newly introduced by 
your changes. Can you see?


> AvaticaCommonsHttpClientImpl client needs to set user-token on 
> HttpClientContext before sending the request
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2503
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2503
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>            Priority: Major
>         Attachments: CALCITE-2503.001.patch
>
>
> One of the Avatica client implementations, AvaticaCommonsHttpClientImpl, uses 
> a PoolingHttpClientConnectionManager. When using mutual authentication on the 
> client pool, we need to ensure that we are setting a user-token on the 
> HttpClientContext, otherwise it ends up creating a new connection everytime 
> and not reusing it. See:  
> [https://hc.apache.org/httpcomponents-client-ga/tutorial/html/advanced.html] 
> for more details
> This results in significant perf degradation since every new connection tries 
> to complete a SSL handshake (which is expensive)
> See: 
> https://stackoverflow.com/questions/548029/how-much-overhead-does-ssl-impose



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to