[
https://issues.apache.org/jira/browse/CALCITE-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16600067#comment-16600067
]
Vladimir Sitnikov commented on CALCITE-2523:
--------------------------------------------
{quote}checkPosetBitsLarge(poset, n=30000, expectedSize=2921,
expectedParentCount=164782);{quote}
1) How do you know that expectedParentCount=164782?
2) testPosetBitsLarge takes 42 seconds on my machine, and testPosetBitsLarge2
takes 8 seconds on my machine.
testPosetBitsLarge2 DOES have Assume.assumeTrue("too slow to run every day",
CalciteAssert.ENABLE_SLOW); while testPosetBitsLarge does not.
Apparently the test just consumes CPU with no reason.
> PartiallyOrderedSetTest#testPosetBitsLarge takes ~80 seconds at Travis
> ----------------------------------------------------------------------
>
> Key: CALCITE-2523
> URL: https://issues.apache.org/jira/browse/CALCITE-2523
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> PartiallyOrderedSetTest#testPosetBitsLarge is quite large, and it performs
> exactly the same computation during test execution.
> I suggest to guard the test like {{testPosetBitsLarge2}} with ENABLE_SLOW:
> {code:java}Assume.assumeTrue("too slow to run every day",
> CalciteAssert.ENABLE_SLOW);{code}
> Alternative options: reduce test complexity to make it faster, and/or
> randomize test execution so it explores new test cases on every execution.
> For instance, it could run for 5 seconds and explore new cases each time.
> Current test is more or less useless, and it does take noticeable CI time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
